Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dummy pr to test deadlock solutions #3098

Closed
wants to merge 14 commits into from
Closed

dummy pr to test deadlock solutions #3098

wants to merge 14 commits into from

Conversation

MiguelBarro
Copy link
Contributor

@MiguelBarro MiguelBarro commented Nov 19, 2022 •
edited
Loading

Description

Testing workarounds for deadlocks in #3087

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Chen Lihui and others added 7 commits November 14, 2022 15:43
fix notification lost
744524a 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
add a regression test
db53f1a 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
rename a variable name and update comments
f1ce5e2 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
fix uncrustify issue
a92143e 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
make the regression test better
3e089ff 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
fix uncrustify
764823a 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@MiguelCompany
Refs #16192. Fix deadlock on WaitSetImpl.
8c60364 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2022

⚠️ The sha of the head commit of this PR conflicts with #3087. Mergify cannot evaluate rules on this PR. ⚠️

Refs 16192. Workaround for deadlock and notify pessimization
3d03c30 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me 🤯

Miguel Barro added 2 commits November 19, 2022 18:37
Refs 16192. Mandatory logic fix
0681786 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 16192. linter
34a8f8d 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me 🤯

@MiguelBarro MiguelBarro changed the title Bugfix/waitset dummy pr to test deadlock solutions Nov 20, 2022
Miguel Barro added 2 commits November 21, 2022 11:46
Refs #16192. Catch up any notification lost
eb389f6 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 16192. Avoid predicate evaluation on spurious wakeups.
90d02d3 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me 🤯

Refs 16192. Fixing gcc warnings
b95d811 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me 🤯

1 similar comment
@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me 🤯

Refs 16192. Allowing wait without previous notification
aa260da 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me 🤯

@MiguelCompany
Copy link
Member

@iuhilnehc-ynos I've been reviewing this again.

I propose to move forward by merging the changes up to commit 34a8f8d. This will reduce the possibility of losing a notification, though there will be a small window where it can be lost, as you mentioned in this comment.

We will later work on using your initial solution (744524a) but fixing the deadlock with ReadCondition.

Thoughts?

@iuhilnehc-ynos
Copy link
Contributor

there will be a small window where it can be lost

I think this PR can fix the lost notification since it can re-check the condition every 500ms, but it will increase CPU consumption.

We will later work on using your initial solution (744524a) but fixing the deadlock with ReadCondition.

Thoughts?

If you think this PR is acceptable, I have no other opinion.

@iuhilnehc-ynos iuhilnehc-ynos mentioned this pull request Jan 5, 2023
Merged
13 tasks
@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2023

⚠️ The sha of the head commit of this PR conflicts with #3087. Mergify cannot evaluate rules on this PR. ⚠️

@MiguelCompany MiguelCompany deleted the bugfix/waitset branch January 5, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuhilnehc-ynos iuhilnehc-ynos iuhilnehc-ynos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelBarro @MiguelCompany @iuhilnehc-ynos